Skip to content

Conversation

@ak-org
Copy link

@ak-org ak-org commented Nov 1, 2024

Description:
This project contains CDK code to provision :

  • An ECS Cluster and one Inf2.xlarge EC2 instance joining the cluster.
  • An ECS Task Definition for Neruon Problem Detector and Recovery
  • An ECS Service that run the containers as Daemon in all instances
  • Related IAM roles and log groups
    Issue #, sim, or t.corp if available:
    N/A
  • Link to RTD for my changes: https://github.com/aws-neuron/aws-neuron-samples-staging/YOUR_BRANCH_NAME/

  • Submitter Checklist

    • Tested on : Neuron SDK , release_version, Instance_type. N/A - Code is to deploy ECS Cluster with inf2.xlarge instances for Nodes.

    • I've completely filled out the form above!
      **(MANDATORY) PR needs test run output

       * I have provided the output with expected metrics in a metrics.json file N/A
      
       * I have attached metric.json in the PR N/A
      
       * I have attached golden_step_loss.txt N/A
      
       * I have added screen shot of plotted loss curve
      
      • (If applicable) I've automated a test to safegaurd my changes from regression. N/A
      • (If applicable) I've posted test collateral to prove my change was effective and not harmful. N/A
      • (If applicable) I've added someone from QA to the list of reviewers. Do this if you didn't make an automated test or feel it's appropriate for another reason. N/A
      • (If applicable) I've reviewed the licenses of updated and new binaries and their dependencies to make sure all licenses are on the pre-approved Amazon license list. N/A
  • Reviewer Checklist
    * I've verified the changes render correctly on RTD (link above)
    * I've ensured the submitter completed the form
    * (If appropriate) I've verified the metrics.json file provided by the submitter

Initial checkin.
Initialized folder and code.
Updated instructions and successfully tested the code.
@harishvs
Copy link

harishvs commented Nov 21, 2024

can we get some eyes on this please? @aws-maens @natemail-aws @rgrandhiamzn

Copy link

@mounchin mounchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clean up files not used and address the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants